Simple fixes #999
Merged
Simple fixes #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2018 16:51
Signed-off-by: Isaac Hier <[email protected]>
Signed-off-by: Isaac Hier <[email protected]>
isaachier
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## grpc #999 +/- ##
=======================================
Coverage ? 99.67%
=======================================
Files ? 139
Lines ? 6397
Branches ? 0
=======================================
Hits ? 6376
Misses ? 21
Partials ? 0
Continue to review full report at Codecov.
|
isaachier
added a commit
to isaachier/jaeger
that referenced
this pull request
Sep 2, 2018
* Fix test error Signed-off-by: Isaac Hier <[email protected]> * go fmt Signed-off-by: Isaac Hier <[email protected]>
isaachier
added a commit
to isaachier/jaeger
that referenced
this pull request
Sep 3, 2018
* Fix test error Signed-off-by: Isaac Hier <[email protected]> * go fmt Signed-off-by: Isaac Hier <[email protected]>
isaachier
added a commit
to isaachier/jaeger
that referenced
this pull request
Sep 3, 2018
* Fix test error Signed-off-by: Isaac Hier <[email protected]> * go fmt Signed-off-by: Isaac Hier <[email protected]>
pavolloffay
pushed a commit
to pavolloffay/jaeger
that referenced
this pull request
Nov 7, 2018
Signed-off-by: Yuri Shkuro <[email protected]> Fix lint Signed-off-by: Yuri Shkuro <[email protected]> Add gRPC endpoint to collector Signed-off-by: Yuri Shkuro <[email protected]> Add proper grpc server Signed-off-by: Yuri Shkuro <[email protected]> Add grpc to all-in-one Signed-off-by: Yuri Shkuro <[email protected]> adds the gRPC port to the docker-all-in-one Dockerfile (jaegertracing#773) (jaegertracing#967) Signed-off-by: Jan Heylen <[email protected]> Simple fixes (jaegertracing#999) * Fix test error Signed-off-by: Isaac Hier <[email protected]> * go fmt Signed-off-by: Isaac Hier <[email protected]> Implement PostSpans for collector gRPC handler Signed-off-by: Isaac Hier <[email protected]> Fix formatting Signed-off-by: Isaac Hier <[email protected]> Remove timeout Signed-off-by: Isaac Hier <[email protected]> Use expectedError variable Signed-off-by: Isaac Hier <[email protected]>
pavolloffay
pushed a commit
to pavolloffay/jaeger
that referenced
this pull request
Nov 8, 2018
Signed-off-by: Yuri Shkuro <[email protected]> Fix lint Signed-off-by: Yuri Shkuro <[email protected]> Add gRPC endpoint to collector Signed-off-by: Yuri Shkuro <[email protected]> Add proper grpc server Signed-off-by: Yuri Shkuro <[email protected]> Add grpc to all-in-one Signed-off-by: Yuri Shkuro <[email protected]> adds the gRPC port to the docker-all-in-one Dockerfile (jaegertracing#773) (jaegertracing#967) Signed-off-by: Jan Heylen <[email protected]> Simple fixes (jaegertracing#999) * Fix test error Signed-off-by: Isaac Hier <[email protected]> * go fmt Signed-off-by: Isaac Hier <[email protected]> Implement PostSpans for collector gRPC handler Signed-off-by: Isaac Hier <[email protected]> Fix formatting Signed-off-by: Isaac Hier <[email protected]> Remove timeout Signed-off-by: Isaac Hier <[email protected]> Use expectedError variable Signed-off-by: Isaac Hier <[email protected]> Agent - collector grpc Signed-off-by: Pavol Loffay <[email protected]> Working collector agent grpc Signed-off-by: Pavol Loffay <[email protected]> Remove what is not needed Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to @yurishkuro's branch for him to include or redo on the grpc branch.