[refactor] Move kafka implementation to internal package #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
added
the
changelog:breaking-change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6651 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 365 365
Lines 20602 20602
=======================================
Hits 19765 19765
Misses 638 638
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Feb 2, 2025
|
Why is this a breaking change? |
@yurishkuro I've been marking all of these PRs as breaking changes in case someone out there is depending on them. Let me know if you'd like me to change them. |
|
Let's not mark them as breaking. We never guaranteed code structure, the fact that we want to untangle circular dependencies with OTEL safely is because it's a partner project. |
mahadzaryab1
added
changelog:bugfix-or-minor-feature
and removed
changelog:breaking-change
yurishkuro
added
changelog:skip
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Feb 11, 2025
…ng#6651) ## Which problem is this PR solving? - Towards jaegertracing#6637 ## Description of the changes - This PR moves the implementation for gRPC storage from `plugin/storage/` to `internal/storage/` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
internal#6637Description of the changes
plugin/storage/tointernal/storage/How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test