-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REPLICATION parameter to Cassandra schema script #6582
Add REPLICATION parameter to Cassandra schema script #6582
Conversation
…ti datacenter support Signed-off-by: asim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create unit tests for this script? Example scripts/utils/compute-tags.test.sh
On it ! |
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6582 +/- ##
==========================================
+ Coverage 96.24% 96.25% +0.01%
==========================================
Files 375 375
Lines 21397 21397
==========================================
+ Hits 20593 20596 +3
+ Misses 612 610 -2
+ Partials 192 191 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
## Which problem is this PR solving? - Subpart of the #6582 ## Description of the changes - created unit tests for the create.sh file , to test for various cases such as presence of Mode parameter , output for specific parameters ## How was this change tested? - ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: asim <[email protected]>
Which problem is this PR solving?
Resoles #2618
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test