Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove unused method from grpc handler #6580

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Removes an unused method for creating a grpc handler

Checklist

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (862f1a3) to head (0f0568a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6580      +/-   ##
==========================================
- Coverage   96.24%   96.24%   -0.01%     
==========================================
  Files         373      373              
  Lines       21406    21389      -17     
==========================================
- Hits        20602    20585      -17     
  Misses        612      612              
  Partials      192      192              
Flag Coverage Δ
badger_v1 10.65% <ø> (+0.01%) ⬆️
badger_v2 2.78% <ø> (+<0.01%) ⬆️
cassandra-4.x-v1-manual 16.61% <ø> (+0.02%) ⬆️
cassandra-4.x-v2-auto 2.71% <ø> (+<0.01%) ⬆️
cassandra-4.x-v2-manual 2.71% <ø> (+<0.01%) ⬆️
cassandra-5.x-v1-manual 16.61% <ø> (+0.02%) ⬆️
cassandra-5.x-v2-auto 2.71% <ø> (+<0.01%) ⬆️
cassandra-5.x-v2-manual 2.71% <ø> (+<0.01%) ⬆️
elasticsearch-6.x-v1 20.39% <ø> (+0.03%) ⬆️
elasticsearch-7.x-v1 20.47% <ø> (+0.04%) ⬆️
elasticsearch-8.x-v1 20.63% <ø> (+0.04%) ⬆️
elasticsearch-8.x-v2 2.77% <ø> (+<0.01%) ⬆️
grpc_v1 12.17% <ø> (+0.01%) ⬆️
grpc_v2 9.04% <ø> (+0.01%) ⬆️
kafka-3.x-v1 10.34% <ø> (+0.01%) ⬆️
kafka-3.x-v2 2.78% <ø> (+<0.01%) ⬆️
memory_v2 2.78% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 20.52% <ø> (+0.03%) ⬆️
opensearch-2.x-v1 20.52% <ø> (+0.04%) ⬆️
opensearch-2.x-v2 2.77% <ø> (-0.01%) ⬇️
tailsampling-processor 0.51% <ø> (+<0.01%) ⬆️
unittests 95.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 976a36e into jaegertracing:main Jan 21, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants