Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix incorrect usage of iter package in aggregator #6403

Merged
merged 3 commits into from
Dec 25, 2024
+10 −2
Merged

[fix] Fix incorrect usage of iter package in aggregator #6403

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbb3d4f
Fix Incorrect Package Usage
mahadzaryab1 Dec 25, 2024
0fdb1d9
Add Linter Rule
mahadzaryab1 Dec 25, 2024
95abcef
Fix Typo
mahadzaryab1 Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Fix Typo 
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1
mahadzaryab1 committed Dec 25, 2024
commit 95abcef85cb29b10f653f411ed2d04e3358ae64f
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ linters-settings:
files:
- "!**/jptrace/**"

# TODO: remove once we have upgraded to Go 1.233
# TODO: remove once we have upgraded to Go 1.23
disallow-iter:
deny:
- pkg: iter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very odd - our go.mod says

go 1.22.7

so it should not have compiled w/ the std iter package