[v2] Add v1 factory converter to v2 storage factory

[james-ryans]

Which problem is this PR solving?

• Part of [jaeger-v2] Change remote storage API to be the same as query service API #5334

Description of the changes

• Current storageextension uses v1 storage factory and transitioning from v1 to v2 requires v2 to implement the v1 storage factory interface. This PR helps by creating a wrapper factory to implement v1 storage factory converted from v2 spanstore interface.

How was this change tested?

• unit tests

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.38%. Comparing base (1c1f22b) to head (603bbbc).

Files	Patch %	Lines
...l/extension/jaegerstorage/factoryadapter/writer.go	87.50%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5497   +/-   ##
=======================================
  Coverage   96.37%   96.38%           
=======================================
  Files         327      329    +2     
  Lines       16028    16056   +28     
=======================================
+ Hits        15447    15475   +28     
  Misses        404      404           
  Partials      177      177           

Flag	Coverage Δ
badger_v1	8.04% <ø> (ø)
badger_v2	1.92% <0.00%> (-0.01%)	⬇️
cassandra-3.x-v1	16.60% <ø> (ø)
cassandra-3.x-v2	1.84% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v1	16.60% <ø> (ø)
cassandra-4.x-v2	1.84% <0.00%> (-0.01%)	⬇️
elasticsearch-7.x-v1	18.87% <ø> (ø)
elasticsearch-8.x-v1	19.06% <ø> (ø)
elasticsearch-8.x-v2	19.06% <ø> (ø)
grpc_v1	9.47% <ø> (ø)
grpc_v2	7.49% <0.00%> (-0.03%)	⬇️
kafka	9.76% <ø> (ø)
opensearch-1.x-v1	18.92% <ø> (ø)
opensearch-2.x-v1	18.92% <ø> (ø)
opensearch-2.x-v2	18.92% <ø> (+0.01%)	⬆️
unittests	94.23% <95.12%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

lgtm. The Reader part is not urgent since we don't have places that would need OTLP (the only place is the api_v3 endpoint).

[yurishkuro]

what's your plan for next steps? Add tests, or try to use this for real?

[james-ryans]

what's your plan for next steps? Add tests, or try to use this for real?

I'm thinking of using this for real directly. Because I think this is a temporary package to support both v1 & v2 while we transitioning the storage plugin implementations to v2. But what do you think about that? Should I add the tests to minimize the error rate?

[yurishkuro]

I think the best way to validate API is to use it! Right now jaegerexporter operates directly on v1 storage API. What would it take to switch it to operate on v2 API? We can make a change to the exporter AND to the jaegerstorage extension such that the latter would provide a lookup method for getting a V2 factory to the exporter, by wrapping v1 factories internally into this new adapter. This will, incidentally, improve the coverage of your new code since it will be exercised in the e2e tests. You might only need to add manual tests for error conditions.

I would consider perhaps pulling the Reader into a separate PR from this one, since jaeger-v2 won't have an easy way to exercise v2->v1 adapter for the read path.

[yurishkuro]

lgtm, can we add some tests?

[james-ryans]

lgtm, can we add some tests?

yes, I'm working on it

[yurishkuro]

🎉