Added unit tests in internal/tracegen #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
764b0a5 to
26cc47b
Compare
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 19, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
26cc47b to
037b831
Compare
|
@yurishkuro could you please trigger the workflows on this PR? Thanks? |
yurishkuro
reviewed
Jan 19, 2024
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 20, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
037b831 to
8252260
Compare
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 20, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
8252260 to
8be267d
Compare
The latest commit increased the coverage of this package to 97%. |
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 20, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
8be267d to
63d964a
Compare
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 20, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
63d964a to
ce4320a
Compare
yurishkuro
reviewed
Jan 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
==========================================
- Coverage 95.62% 95.59% -0.03%
==========================================
Files 322 324 +2
Lines 18454 18566 +112
==========================================
+ Hits 17646 17749 +103
- Misses 649 655 +6
- Partials 159 162 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 20, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
ce4320a to
22b092c
Compare
yurishkuro
approved these changes
Jan 20, 2024
yurishkuro
added
the
changelog:test
|
If the code coverage above 95%, you should remove .nocover file in this package |
VaibhavMalik4187
added a commit
to VaibhavMalik4187/jaeger
that referenced
this pull request
Jan 21, 2024
- Partially fixes jaegertracing#5068 - This commit adds tests for the `Run` function defined in the `internal/tracegen` package. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
22b092c to
160be25
Compare
Okay, removed it. |
- Partially fixes jaegertracing#5068 - This commit adds tests tests in the `internal/tracegen` package, bringing the package coverage to 97%. - make test - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
internal-tracegen-tests
branch
from
160be25 to
fd452e5
Compare
|
Thanks for merging |
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
internal/tracegenpackage.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test