Add unit tests in cmd/jaeger/internal

cmd/jaeger/internal/command.go

@@ -40,21 +40,30 @@
 	// are present in the args. If not, we create one with all-in-one configuration.
 	otelRunE := cmd.RunE
 	cmd.RunE = func(cmd *cobra.Command, args []string) error {
-		configFlag := cmd.Flag("config")
-		if !configFlag.Changed {
-			log.Print("No '--config' flags detected, using default All-in-One configuration with memory storage.")
-			log.Print("To customize All-in-One behavior, pass a proper configuration.")
-			data, err := yamlAllInOne.ReadFile("all-in-one.yaml")
-			if err != nil {
-				return fmt.Errorf("cannot read embedded all-in-one configuration: %w", err)
-			}
-			configFlag.Value.Set("yaml:" + string(data))
-		}
-		return otelRunE(cmd, args)
+		return checkConfigAndRun(cmd, args, yamlAllInOne.ReadFile, otelRunE)
 	}
 
 	cmd.Short = description
 	cmd.Long = description
 
 	return cmd
 }
+
+func checkConfigAndRun(
+	cmd *cobra.Command,
+	args []string,
+	getCfg func(name string) ([]byte, error),
+	runE func(cmd *cobra.Command, args []string) error,
+) error {
+	configFlag := cmd.Flag("config")
+	if !configFlag.Changed {
+		log.Print("No '--config' flags detected, using default All-in-One configuration with memory storage.")
+		log.Print("To customize All-in-One behavior, pass a proper configuration.")
+		data, err := getCfg("all-in-one.yaml")
+		if err != nil {
+			return fmt.Errorf("cannot read embedded all-in-one configuration: %w", err)
+		}
+		configFlag.Value.Set("yaml:" + string(data))
+	}
+	return runE(cmd, args)
+}

cmd/jaeger/internal/command_test.go

@@ -0,0 +1,56 @@
+// Copyright (c) 2024 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"testing"
+
+	"github.com/spf13/cobra"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestCommand(t *testing.T) {
+	cmd := Command()
+
+	assert.NotNil(t, cmd)
+	assert.Equal(t, "jaeger", cmd.Use)
+	assert.Equal(t, description, cmd.Long)
+
+	runE := cmd.RunE
+	assert.NotNil(t, runE)
+}
+
+func TestCheckConfigAndRun_DefaultConfig(t *testing.T) {
+	cmd := &cobra.Command{
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return nil
+		},
+	}
+	cmd.Flags().String("config", "", "path to config file")
+	getCfg := func(name string) ([]byte, error) {
+		return []byte("default-config"), nil
+	}
+	runE := func(cmd *cobra.Command, args []string) error {
+		return nil
+	}
+
+	err := checkConfigAndRun(cmd, nil, getCfg, runE)
+	require.NoError(t, err)
+
+	configFlag := cmd.Flag("config")
+	assert.Equal(t, "yaml:default-config", configFlag.Value.String())
+	assert.False(t, configFlag.Changed)
+}

cmd/jaeger/internal/components_test.go

@@ -0,0 +1,37 @@
+// Copyright (c) 2024 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestComponents(t *testing.T) {
+	factories, err := components()
+
+	require.NoError(t, err)
+
+	assert.NotNil(t, factories.Extensions)
+	assert.NotNil(t, factories.Receivers)
+	assert.NotNil(t, factories.Exporters)
+	assert.NotNil(t, factories.Processors)
+	assert.NotNil(t, factories.Connectors)
+
+	_, jaegerReceiverFactoryExists := factories.Receivers["jaeger"]
+	assert.True(t, jaegerReceiverFactoryExists)
+}

cmd/jaeger/internal/package_test.go

@@ -0,0 +1,25 @@
+// Copyright (c) 2024 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package internal
+
+import (
+	"testing"
+
+	"github.com/jaegertracing/jaeger/pkg/testutils"
+)
+
+func TestMain(m *testing.M) {
+	testutils.VerifyGoLeaks(m)
+}