test: Added goleak to TestMain in cmd/collector/app/server package folder

cmd/collector/app/server/grpc_test.go

@@ -21,6 +21,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"go.opencensus.io/stats/view"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
 	"go.uber.org/zap/zaptest/observer"
@@ -35,6 +36,13 @@ import (
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2"
 )
 
+func stopOpenCensus(t *testing.T) {
+	t.Cleanup(func() {
+		// Stop opencensus.io default worker
+		defer view.Stop()
+	})
+}
+
 // test wrong port number
 func TestFailToListen(t *testing.T) {
 	logger, _ := zap.NewDevelopment()
@@ -46,6 +54,7 @@ func TestFailToListen(t *testing.T) {
 	})
 	assert.Nil(t, server)
 	require.EqualError(t, err, "failed to listen on gRPC port: listen tcp: address -1: invalid port")
+	stopOpenCensus(t)
 }
 
 func TestFailServe(t *testing.T) {
@@ -56,7 +65,9 @@ func TestFailServe(t *testing.T) {
 	wg.Add(1)
 
 	logger := zap.New(core)
-	serveGRPC(grpc.NewServer(), lis, &GRPCServerParams{
+	server := grpc.NewServer()
+	defer server.Stop()
+	serveGRPC(server, lis, &GRPCServerParams{
 		Handler:       handler.NewGRPCHandler(logger, &mockSpanProcessor{}, &tenancy.Manager{}),
 		SamplingStore: &mockSamplingStore{},
 		Logger:        logger,
@@ -67,6 +78,7 @@ func TestFailServe(t *testing.T) {
 		},
 	})
 	wg.Wait()
+	stopOpenCensus(t)
 }
 
 func TestSpanCollector(t *testing.T) {
@@ -107,10 +119,11 @@ func TestCollectorStartWithTLS(t *testing.T) {
 			ClientCAPath: testCertKeyLocation + "/example-CA-cert.pem",
 		},
 	}
-
+	stopOpenCensus(t)
 	server, err := StartGRPCServer(params)
 	require.NoError(t, err)
-	defer server.Stop()
+	server.Stop()
+	params.TLSConfig.Close()
 }
 
 func TestCollectorReflection(t *testing.T) {

cmd/collector/app/server/http_test.go

@@ -64,26 +64,30 @@ func TestCreateTLSHTTPServerError(t *testing.T) {
 	}
 	_, err := StartHTTPServer(params)
 	require.Error(t, err)
+	params.TLSConfig.Close()
 }
 
 func TestSpanCollectorHTTP(t *testing.T) {
+	mFact := metricstest.NewFactory(time.Hour)
+	defer mFact.Backend.Stop()
 	logger, _ := zap.NewDevelopment()
 	params := &HTTPServerParams{
 		Handler:        handler.NewJaegerSpanHandler(logger, &mockSpanProcessor{}),
 		SamplingStore:  &mockSamplingStore{},
-		MetricsFactory: metricstest.NewFactory(time.Hour),
+		MetricsFactory: mFact,
 		HealthCheck:    healthcheck.New(),
 		Logger:         logger,
 	}
 
 	server := httptest.NewServer(nil)
-	defer server.Close()
 
 	serveHTTP(server.Config, server.Listener, params)
 
 	response, err := http.Post(server.URL, "", nil)
 	require.NoError(t, err)
 	assert.NotNil(t, response)
+	response.Body.Close()
+	server.Close()
 }
 
 func TestSpanCollectorHTTPS(t *testing.T) {
@@ -191,15 +195,18 @@ func TestSpanCollectorHTTPS(t *testing.T) {
 			// Cannot reliably use zaptest.NewLogger(t) because it causes race condition
 			// See https://github.com/jaegertracing/jaeger/issues/4497.
 			logger := zap.NewNop()
+			mFact := metricstest.NewFactory(time.Hour)
+			defer mFact.Backend.Stop()
 			params := &HTTPServerParams{
 				HostPort:       fmt.Sprintf(":%d", ports.CollectorHTTP),
 				Handler:        handler.NewJaegerSpanHandler(logger, &mockSpanProcessor{}),
 				SamplingStore:  &mockSamplingStore{},
-				MetricsFactory: metricstest.NewFactory(time.Hour),
+				MetricsFactory: mFact,
 				HealthCheck:    healthcheck.New(),
 				Logger:         logger,
 				TLSConfig:      test.TLS,
 			}
+			defer params.TLSConfig.Close()
 
 			server, err := StartHTTPServer(params)
 			require.NoError(t, err)
@@ -208,6 +215,7 @@ func TestSpanCollectorHTTPS(t *testing.T) {
 			}()
 
 			clientTLSCfg, err0 := test.clientTLS.Config(logger)
+			defer test.clientTLS.Close()
 			require.NoError(t, err0)
 			dialer := &net.Dialer{Timeout: 2 * time.Second}
 			conn, clientError := tls.DialWithDialer(dialer, "tcp", "localhost:"+fmt.Sprintf("%d", ports.CollectorHTTP), clientTLSCfg)
@@ -240,18 +248,21 @@ func TestSpanCollectorHTTPS(t *testing.T) {
 			} else {
 				require.NoError(t, requestError)
 				require.NotNil(t, response)
+				response.Body.Close()
 			}
 		})
 	}
 }
 
 func TestStartHTTPServerParams(t *testing.T) {
 	logger := zap.NewNop()
+	mFact := metricstest.NewFactory(time.Hour)
+	defer mFact.Stop()
 	params := &HTTPServerParams{
 		HostPort:          fmt.Sprintf(":%d", ports.CollectorHTTP),
 		Handler:           handler.NewJaegerSpanHandler(logger, &mockSpanProcessor{}),
 		SamplingStore:     &mockSamplingStore{},
-		MetricsFactory:    metricstest.NewFactory(time.Hour),
+		MetricsFactory:    mFact,
 		HealthCheck:       healthcheck.New(),
 		Logger:            logger,
 		IdleTimeout:       5 * time.Minute,

cmd/collector/app/server/server_test.go

@@ -0,0 +1,25 @@
+// Copyright (c) 2023 The Jaeger Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package server
+
+import (
+	"testing"
+
+	"go.uber.org/goleak"
+)
+
+func TestMain(m *testing.M) {
+	goleak.VerifyTestMain(m)
+}