Handle ports > 32k in Zipkin JSON #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
yurishkuro
changed the title
black-adder
approved these changes
Oct 23, 2017
| deadline := time.Now().Add(2 * time.Second) | ||
| for { | ||
| if time.Now().After(deadline) { | ||
| t.Error("never received a span") | ||
| return | ||
| } | ||
| if want, have := 1, len(handler.zipkinSpansHandler.(*mockZipkinHandler).getSpans()); want != have { | ||
| if want, have := expecting, len(handler.getSpans()); want != have { |
There was a problem hiding this comment.
is "want" necessary? just do
if have := ....; expected != have {
cmd/collector/app/zipkin/json.go
Outdated
| @@ -147,10 +147,15 @@ func endpointToThrift(e endpoint) (*zipkincore.Endpoint, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| port := e.Port | |||
| if port >= (1 << 15) { | |||
| // Zipkin.thrift defines port as i16, so values between (2^16 and 2^16-1) must be encoded as negative | |||
Signed-off-by: Yuri Shkuro <[email protected]>
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #467