-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add the label-check workflow to verify changelog labels on each PR #4847
Conversation
Signed-off-by: Ansh Goyal <[email protected]>
Signed-off-by: Ansh Goyal <[email protected]>
Signed-off-by: Ansh Goyal <[email protected]>
Signed-off-by: Ansh Goyal <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Signed-off-by: Ansh Goyal <[email protected]>
Signed-off-by: Ansh Goyal <[email protected]>
Signed-off-by: Ansh Goyal <[email protected]>
closed? |
This workflow was working correctly but later I realized that I couldn't solve the complete issue of modifying the release scripts as I don't know Python :( |
I am currently trying out the modification to the Python script as I learn it. In the meantime, others can try their own approach. Merging this PR would have constrained me to resolve the other part of the issue quickly, as no other folk would then try out their hand thereafter. |
Having a check on PRs before merging is an independent of whether we have a release script making use of that. There seems to be in-progress PR for the latter #4849 |
I managed to modify the python script also, but #4849 seems to have a better approach. Feel free to play with the PR by adding/removing labels and verify if the action is working properly |
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Ansh Goyal <[email protected]>
Which problem is this PR solving?
Description of the changes
bug
on the PR, workflow would again run, but would still fail since the labelbug
doesn't start withchangelog:
changelog:**
, this time, Label Check CI would pass.How was this change tested?
changelog: feature
: Passing GH Action: https://github.com/anshgoyalevil/jaeger/actions/runs/6531596646/attempts/3bug
and notchangelog: feature
: https://github.com/anshgoyalevil/jaeger/actions/runs/6531596646/attempts/4bug
,documentation
, andchangelog: feature
: https://github.com/anshgoyalevil/jaeger/actions/runs/6531596646How to test this PR?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test
.