Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Fix failing e2e test for Cassandra storage #4776

Merged
merged 6 commits into from
Sep 29, 2023
Merged

[tests] Fix failing e2e test for Cassandra storage #4776

merged 6 commits into from
Sep 29, 2023

Conversation

slayer321
Copy link
Contributor

@slayer321 slayer321 commented Sep 25, 2023 •
edited
Loading

Which problem is this PR solving?

Resolves #4782

Description of the changes

  • Recently a PR was raised to run all integration tests against Cassandra while checking it's CI for cassandra I found that the some test where failing but CI passed.
  • Fixed the script so that if the test fail we get exit code as non-zero.
  • Fixed TestCassandraStorage/GetLargeSpans test which was failing due to older traces not getting cleanup from db.

How was this change tested?

  • run the cassandra script to test it.

Checklist

@slayer321 slayer321 changed the title fix: e2e test failing for cassandra storage fix: failing e2e test for cassandra storage Sep 25, 2023
@slayer321 slayer321 force-pushed the fix-failing-cassendra-e2e-test branch from 7b57221 to 67f0217 Compare September 29, 2023 05:40
@slayer321 slayer321 marked this pull request as ready for review September 29, 2023 05:40
@slayer321 slayer321 requested a review from a team as a code owner September 29, 2023 05:40
@slayer321 slayer321 requested a review from jkowall September 29, 2023 05:40
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
plugin/storage/cassandra/factory.go 95.28% <0.00%> (-1.84%) ⬇️
plugin/storage/integration/integration.go 73.18% <0.00%> (-0.27%) ⬇️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@slayer321 slayer321 mentioned this pull request Sep 29, 2023
Open
@yurishkuro yurishkuro changed the title fix: failing e2e test for cassandra storage [tests] Fix failing e2e test for Cassandra storage Sep 29, 2023
@yurishkuro yurishkuro merged commit 847b260 into jaegertracing:main Sep 29, 2023
@yurishkuro yurishkuro mentioned this pull request Sep 29, 2023
Merged
yurishkuro added a commit that referenced this pull request Sep 29, 2023
@yurishkuro
[tests] Simplify Cassandra e2e test cleanup (#4794)
b876332 
Follow-up on #4776

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro mentioned this pull request Oct 8, 2023
Merged
yurishkuro added a commit that referenced this pull request Oct 8, 2023
@yurishkuro
Skip Multiple_traces integration test for Cassandra (#4825)
532afc3 
## Which problem is this PR solving?
- Cassandra tests started failing frequently, once more tests were
enabled (in #4776)

## Description of the changes
- Skip `Multiple Traces` test

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Storage integration tests can fail queitly
2 participants
@slayer321 @yurishkuro