Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Enable BlockOnQueueFull in OTel SDK to avoid dropped spans #4578

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

haanhvu
Copy link
Contributor

@haanhvu haanhvu commented Jul 11, 2023

Which problem is this PR solving?

[tracegen] Enable BlockOnQueueFull in OTel SDK to make spans not dropped in spikes

Short description of the changes

Call WithBlocking() from OTel SDK to enable BlockOnQueueFull=true to make spans not dropped when the queue is full.

Tested locally:

  • Before the change: Spans in tracegen were dropped when generated to jaeger-collector, even with just 1m duration and 1 worker.
  • With the change: Spans in tracegen were not dropped even with 1h duration and 10 workers.

Screenshot 2023-07-12 005149

@haanhvu haanhvu requested a review from a team as a code owner July 11, 2023 18:08
@haanhvu haanhvu requested a review from joe-elliott July 11, 2023 18:08
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (e2057fe) 97.05% compared to head (4a64ff0) 97.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4578      +/-   ##
==========================================
+ Coverage   97.05%   97.07%   +0.01%     
==========================================
  Files         301      301              
  Lines       17837    17837              
==========================================
+ Hits        17312    17315       +3     
+ Misses        421      419       -2     
+ Partials      104      103       -1     
Flag Coverage Δ
unittests 97.07% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro
Copy link
Member

@haanhvu in the future, use a branch in a fork to create PRs, don't do it from main. It both breaks the CI and makes it harder for you to keep main in sync with upstream.

@yurishkuro yurishkuro changed the title [tracegen] Enable BlockOnQueueFull in OTel SDK to make spans not dropped in spikes [tracegen] Enable BlockOnQueueFull in OTel SDK to prevent spans being dropped on full queue Jul 11, 2023
@yurishkuro yurishkuro changed the title [tracegen] Enable BlockOnQueueFull in OTel SDK to prevent spans being dropped on full queue [tracegen] Enable BlockOnQueueFull in OTel SDK to avoid dropped spans Jul 11, 2023
@yurishkuro yurishkuro merged commit e40a3e5 into jaegertracing:main Jul 11, 2023
@haanhvu
Copy link
Contributor Author

haanhvu commented Jul 12, 2023

@haanhvu in the future, use a branch in a fork to create PRs, don't do it from main. It both breaks the CI and makes it harder for you to keep main in sync with upstream.

Yeah, I just did a super quick change on main since it's a tiny PR. Forgot that CI didn't accept it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants