Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/apache/thrift from 0.14.1 to 0.14.2 #3097

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 18, 2021

Bumps github.com/apache/thrift from 0.14.1 to 0.14.2.

Release notes

Sourced from github.com/apache/thrift's releases.

Version 0.14.2

For release 0.14.0 head over to the official release download source: http://thrift.apache.org/download

The assets below are added by Github based on the release tag and they may therefore not match the checkums.

Changelog

Sourced from github.com/apache/thrift's changelog.

0.14.2

Java

  • THRIFT-5383 - THRIFT-5383 TJSONProtocol Java readString throws on bounds check

Go

  • THRIFT-5369 - No longer pre-allocating the whole container (map/set/list) in compiled go code to avoid huge allocations on malformed messages
Commits
  • 57e24ca THRIFT-5369: Use MaxMessageSize to check container sizes
  • 63e86ce Version 0.14.2
  • d604602 THRIFT-5383 TJSONProtocol Java readString throws on bounds check
  • c1e33a8 version 0.14.1
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/apache/thrift](https://github.com/apache/thrift) from 0.14.1 to 0.14.2.
- [Release notes](https://github.com/apache/thrift/releases)
- [Changelog](https://github.com/apache/thrift/blob/master/CHANGES.md)
- [Commits](apache/thrift@v0.14.1...v0.14.2)

---
updated-dependencies:
- dependency-name: github.com/apache/thrift
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner June 18, 2021 04:23
@dependabot dependabot bot requested a review from vprithvi June 18, 2021 04:23
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #3097 (41edd41) into master (2071fee) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3097      +/-   ##
==========================================
- Coverage   95.93%   95.89%   -0.04%     
==========================================
  Files         235      235              
  Lines       10143    10143              
==========================================
- Hits         9731     9727       -4     
- Misses        343      346       +3     
- Partials       69       70       +1     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.20% <0.00%> (-2.60%) ⬇️
plugin/storage/badger/spanstore/reader.go 95.37% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2071fee...41edd41. Read the comment docs.

@pavolloffay pavolloffay merged commit 13885e5 into master Jun 18, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/apache/thrift-0.14.2 branch June 18, 2021 09:24
@jpkrohling jpkrohling added this to the Release 1.24.0 milestone Jun 22, 2021
@jpkrohling
Copy link
Contributor

The go.mod should have had the replace directive removed:

jaeger/go.mod

Lines 73 to 74 in 9ee807d

// TODO: remove once the 0.14.2 or 0.15.0 is released
replace github.com/apache/thrift => github.com/jaegertracing/thrift v0.14.1-patch1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants