-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use withResolver API in gRPC reporter #3078
Merged
yurishkuro
merged 4 commits into
jaegertracing:master
from
pavolloffay:grpc-withresolver
Jun 11, 2021
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can somebody explain why are we using a random scheme and what it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/grpc/grpc-go/blob/master/dialoptions.go#L609
Is the random scheme to prevent it from ever being matched? Can this code just be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test suite failed when I didn't call
WithResolvers
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, not 100% sure but i've done some code diving:
https://github.com/grpc/grpc-go/blob/b1f7648a9fc72ce76cbcd42d8e2c60d9d9bed9fc/clientconn.go#L251
when the dialer wants to choose its resolver it looks for one matching the scheme of the target. On this line we're just using the resolver scheme when creating the target:
This basically guarantees that our target scheme lines up with the resolver scheme and the right resolver is chosen. I believe it's a random number so it never conflicts with a "real resolver":
https://github.com/grpc/grpc-go/blob/master/internal/resolver/passthrough/passthrough.go#L25
https://github.com/grpc/grpc-go/blob/master/internal/resolver/dns/dns_resolver.go#L158
We could leave it as a random number or we could change it to something like
jaeger_manual
if we're feeling fancy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's feel fancy in this case, I like the predictability :)