Add: support specifying cipher suites in tls connection #3019 #3026
Conversation
clock21am
force-pushed
the
rajdeep/issue-3019
branch
from
ae6cbd1 to
986a4ce
Compare
|
@yurishkuro Let me know what do you think? |
pkg/config/tlscfg/options.go
Outdated
| @@ -18,6 +18,7 @@ import ( | |||
| "crypto/tls" | |||
| "crypto/x509" | |||
| "fmt" | |||
| "github.com/coreos/etcd/pkg/tlsutil" | |||
There was a problem hiding this comment.
I don't think we want an external dependency for such minor functionality. Also, I am not seeing this package in https://github.com/etcd-io/etcd/tree/main/pkg
There was a problem hiding this comment.
@yurishkuro removed this external dependency and made it a sample. Hope this makes sense.
There was a problem hiding this comment.
as it was mentioned in this document https://docs.fluentd.org/configuration/transport-section#tls-setting do you want to provide some default cipher in the repo itself?
There was a problem hiding this comment.
and one more doubt why naming ciphers if want to pass just string ? are we expecting multiple ciphers ?
clock21am
force-pushed
the
rajdeep/issue-3019
branch
from
986a4ce to
e47eeab
Compare
…#3019 Signed-off-by: Rajdeep Kaur <[email protected]>
clock21am
force-pushed
the
rajdeep/issue-3019
branch
from
e47eeab to
4a7310c
Compare
|
I have questions on the original ticket. |
|
What's the status of this PR? |
|
@jpkrohling there were questions on the original tickets have to look but haven’t got the chance can take a look in the evening though |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
|
Already addressed by #3564 |
Which problem is this PR solving?
Short description of the changes