Increase test timeout for TestKafkaStorage #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Goldsworthy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
==========================================
- Coverage 95.97% 95.95% -0.03%
==========================================
Files 223 223
Lines 9685 9685
==========================================
- Hits 9295 9293 -2
- Misses 322 324 +2
Partials 68 68
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Mar 10, 2021
| @@ -36,7 +36,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| iterations = 30 | |||
| iterations = 40 | |||
There was a problem hiding this comment.
Acked writes didn't seem to help unfortunately. I attempted to switch the acks to "local" as well as "all" to no avail. I'm guessing the ack never actually comes into effect because there is probably a timeout on the message transfer that is greater than the test time we have set. I ran kafkacat to see if the spans ever made it to the cluster and it seemed like the messages would always make it after some time.
… 2760-flaky-kafka-storage-test
Signed-off-by: Jacob Goldsworthy <[email protected]>
mergify
bot
dismissed
albertteoh’s stale review
Pull request has been modified.
yurishkuro
approved these changes
Mar 11, 2021
yurishkuro
changed the title
yurishkuro
changed the title
|
thanks @LostLaser |
dgrizzanti
pushed a commit
to dgrizzanti/jaeger
that referenced
this pull request
Mar 12, 2021
* Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]>
dgrizzanti
pushed a commit
to dgrizzanti/jaeger
that referenced
this pull request
Mar 13, 2021
* Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]>
dgrizzanti
pushed a commit
to dgrizzanti/jaeger
that referenced
this pull request
Mar 13, 2021
* Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]>
dgrizzanti
pushed a commit
to dgrizzanti/jaeger
that referenced
this pull request
Mar 13, 2021
* Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]>
dgrizzanti
pushed a commit
to dgrizzanti/jaeger
that referenced
this pull request
Mar 13, 2021
* Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]>
yurishkuro
pushed a commit
that referenced
this pull request
Mar 16, 2021
* Add remote read clusters option to elasticsearch to enable cross-cluster querying Co-authored-by: allen13 <[email protected]> Signed-off-by: David Grizzanti <[email protected]> * Increase test timeout for TestKafkaStorage (#2873) * Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]> * Rename indexName to indexPrefix; short circuit addRemoteReadClusters when remoteReadClusters is emtpy Signed-off-by: David Grizzanti <[email protected]> * Add more test cases for remoteReadClusters with Archive: true and UseReadWriteAliases: true Signed-off-by: David Grizzanti <[email protected]> * Removing unnecessary changes from this PR Signed-off-by: David Grizzanti <[email protected]> * Increase test timeout for TestKafkaStorage (#2873) * Increasing test timeout to allow for trace storage settle Signed-off-by: Jacob Goldsworthy <[email protected]> * Updating max storage test wait time to 10 seconds Signed-off-by: Jacob Goldsworthy <[email protected]> Signed-off-by: David Grizzanti <[email protected]> * Update variable name for consistency Signed-off-by: David Grizzanti <[email protected]> * Fix index prefix name Signed-off-by: David Grizzanti <[email protected]> * Prevent remoteReadClusters from being []string{""} when no remote clusters are provided Signed-off-by: David Grizzanti <[email protected]> Co-authored-by: allen13 <[email protected]> Co-authored-by: Jacob G <[email protected]>
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Goldsworthy [email protected]
Which problem is this PR solving?
Short description of the changes