Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue for Elasticsearch CI failures #2678

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Fix issue for Elasticsearch CI failures #2678

merged 4 commits into from
Dec 2, 2020

Conversation

Ashmita152
Copy link
Contributor

Signed-off-by: Ashmita Bohara [email protected]

Which problem is this PR solving?

Around 10 hours back, python:3-alpine image was upgraded which bumped the pip version from 20.2 to 20.3.

docker

elasticsearch-curator library has hard requirement of elasticsearch lib v7.1.0 (https://github.com/elastic/curator/blob/master/setup.cfg#L26) which isn't compatible with our escleanup.py.

You can see the failure build where elasticsearch-py is being downgraded to v7.1.0.

Collecting elasticsearch
Downloading elasticsearch-7.10.0-py2.py3-none-any.whl (321 kB)
Requirement already satisfied: urllib3<2,>=1.21.1 in /usr/local/lib/python3.9/site-packages (from elasticsearch) (1.24.3)
Collecting elasticsearch-curator
Downloading elasticsearch_curator-5.8.3-py2.py3-none-any.whl (106 kB)
Requirement already satisfied: urllib3<2,>=1.21.1 in /usr/local/lib/python3.9/site-packages (from elasticsearch) (1.24.3)
Collecting elasticsearch
Downloading elasticsearch-7.1.0-py2.py3-none-any.whl (83 kB)

Picking it from previous successful run, there is no downgrade.

Collecting elasticsearch
Downloading elasticsearch-7.10.0-py2.py3-none-any.whl (321 kB)
Collecting elasticsearch-curator
Downloading elasticsearch_curator-5.8.3-py2.py3-none-any.whl (106 kB)

Making image to use a python image with pip 20.2 should fix this issue.

@Ashmita152 Ashmita152 requested a review from a team as a code owner December 2, 2020 12:06
@Ashmita152 Ashmita152 requested a review from vprithvi December 2, 2020 12:06
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #2678 (ebc72f4) into master (a9feab7) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
- Coverage   95.57%   95.54%   -0.04%     
==========================================
  Files         214      214              
  Lines        9535     9535              
==========================================
- Hits         9113     9110       -3     
- Misses        344      346       +2     
- Partials       78       79       +1     
Impacted Files Coverage Δ
plugin/storage/badger/spanstore/reader.go 95.37% <0.00%> (-0.72%) ⬇️
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d75d3c...ebc72f4. Read the comment docs.

@mergify mergify bot requested a review from jpkrohling December 2, 2020 12:19
@albertteoh
Copy link
Contributor

Nice pickup, @Ashmita152 . This should hopefully fix @sniperking1234 's build issues in #2637

@Ashmita152
Copy link
Contributor Author

Thank you @albertteoh

This reverts commit 5d4fde1.

Signed-off-by: Ashmita Bohara <[email protected]>
@Ashmita152
Copy link
Contributor Author

This fix isn't the proper fix but it will unblock the jobs.

It seems like it is related with the warning we get in the CI job.

ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

@jpkrohling jpkrohling merged commit ea127a1 into jaegertracing:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants