Fix docker login issue with all-in-one build

[Ashmita152]

Signed-off-by: Ashmita Bohara [email protected]

Which problem is this PR solving?

Remove docker login command since that is being done as part of GitHub Actions.

Short description of the changes

Also remove the extra check for deleting the config.json. I think it was done to prevent any previous docker login session in the same travis runner machine.

[codecov]

Codecov Report

Merging #2668 (8f91022) into master (da430fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2668   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         213      213           
  Lines        9491     9491           
=======================================
  Hits         9027     9027           
  Misses        387      387           
  Partials       77       77           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da430fa...8f91022. Read the comment docs.

[Ashmita152]

I think long back BRANCH was evaluated as /refs/head/branch-name and hence it was done to remove / from branch name since that will result in docker tag:

$ a="/refs/head/foobar"
$ echo ${a///}
refsheadfoobar

And / isn't allowed in docker tag:

$ docker tag jaegertracing/jaeger-ingester jaegertracing/jaeger-ingester:testing/testing
Error parsing reference: "jaegertracing/jaeger-ingester:testing/testing" is not a valid repository/tag: invalid reference format
$ docker tag jaegertracing/jaeger-ingester jaegertracing/jaeger-ingester:testing
$

Now we are making sure that as part of Github Actions so probably don't require.

[yurishkuro]

Do you have a handy doc link on the substitution syntax?

[Ashmita152]

@yurishkuro I just played around with bash

Here we are replacing refs with test

$ echo $a
/refs/head/foobar
$ echo ${a/ref/test}
/test/head/foobar
$

My understanding of why three backslash:

• First backslash signifies that we are going to do string substitution.
• Second blackslash is to escape third backslash.
• Third backslash is the character to replace.
• No character after means replacing with empty string.

[yurishkuro]

bummer, build failed again

./scripts/travis/upload-to-docker.sh: line 20: TRAVIS_BRANCH: unbound variable
Error: Process completed with exit code 1.

[Ashmita152]

It was a great idea to add set -u It caught it.