-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fossa-contrib/fossa-action instead #2571
Conversation
d34e3f2
to
79c0996
Compare
Codecov Report
@@ Coverage Diff @@
## master #2571 +/- ##
==========================================
+ Coverage 95.06% 95.31% +0.24%
==========================================
Files 210 208 -2
Lines 9410 9281 -129
==========================================
- Hits 8946 8846 -100
+ Misses 387 357 -30
- Partials 77 78 +1
Continue to review full report at Codecov.
|
1cbc70a
to
bdc6eef
Compare
Signed-off-by: Sora Morimoto <[email protected]>
bdc6eef
to
4d89191
Compare
Signed-off-by: Sora Morimoto <[email protected]>
run: echo "GOPATH=$(go env GOPATH)" >>"$GITHUB_ENV" | ||
|
||
- name: Add GOPATH to GITHUB_PATH | ||
run: echo "$GOPATH/bin" >>"$GITHUB_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Do these GITHUB_ENV/GITHUB_PATH vars contain file names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this probably what you are looking for?
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also not clear to me why this is needed. Perhaps leave a comment in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, all it does is expose the GOPATH environment variable and add GOPATH to the PATH. Of course, we can do it more typically. Or are you asking why these are necessary? If so, it's necessary because fossa-cli needs them when it analyzes.
run: echo "$GOPATH/bin" >>"$GITHUB_PATH" | ||
|
||
- name: Run FOSSA scan and upload build data | ||
uses: fossa-contrib/fossa-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this an official action under github.com/fossas ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this isn't an official action yet.
@Mergifyio rebase |
Command
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check seems to work, but just need a clarification on the "Add GOPATH" steps.
run: echo "GOPATH=$(go env GOPATH)" >>"$GITHUB_ENV" | ||
|
||
- name: Add GOPATH to GITHUB_PATH | ||
run: echo "$GOPATH/bin" >>"$GITHUB_PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also not clear to me why this is needed. Perhaps leave a comment in the code?
@smorimoto, are you still interested in this one? |
Oh, I'm sorry I missed it. |
Thanks! |
* Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
* Bump opentelemetry-collector to v0.14.0 (jaegertracing#2617) * bump opentelemetry-collector to v0.14.0 Signed-off-by: Pavel Kositsyn <[email protected]> * initialize traceid and spanid explicitly Signed-off-by: Pavel Kositsyn <[email protected]> * fix comments and empty parent span check Signed-off-by: Pavel Kositsyn <[email protected]> * fasten convert traceID/spanID Signed-off-by: Pavel Kositsyn <[email protected]> * fix convertTraceID + fix tests Signed-off-by: Pavel Kositsyn <[email protected]> * Update CodeQL to latest best practices (jaegertracing#2615) This will parallelize your analysis and speed things up a bunch. Signed-off-by: jhutchings1 <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> * Fix flaky TestReload (jaegertracing#2624) Signed-off-by: albertteoh <[email protected]> * Update x/text to v0.3.4 (jaegertracing#2625) Signed-off-by: Gary Brown <[email protected]> * Bump to latest UI for snapshot builds (jaegertracing#2626) Signed-off-by: Yuri Shkuro <[email protected]> * Implement anonymizer's main program (jaegertracing#2621) * Preparing release 1.21.0 (jaegertracing#2630) * updated changelog Signed-off-by: Joe Elliott <[email protected]> * Added ui changelog Signed-off-by: Joe Elliott <[email protected]> * Fixed UI changelog to point to 1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Updated jaeger-ui to v1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Resolving concerns Signed-off-by: Joe Elliott <[email protected]> * [anonymizer] Save trace in UI format (jaegertracing#2629) * Use fossa-contrib/fossa-action instead (jaegertracing#2571) * Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * Update Makefile and Dockerfile for anonymizer (jaegertracing#2632) Signed-off-by: Ashmita Bohara <[email protected]> * Fix listen IP in unit test (jaegertracing#2636) Signed-off-by: zouyu <[email protected]> * Bump opentelemetry to v0.15.0 (jaegertracing#2634) * Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <[email protected]> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <[email protected]> * make lint Signed-off-by: Pavel Kositsyn <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]> Co-authored-by: Justin Hutchings <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Albert <[email protected]> Co-authored-by: Gary Brown <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Ashmita <[email protected]> Co-authored-by: Joe Elliott <[email protected]> Co-authored-by: Sora Morimoto <[email protected]> Co-authored-by: ZouYu <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]>
Which problem is this PR solving?
Short description of the changes