Add grpc storage plugin OTEL exporter #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
requested review from
jpkrohling and
objectiser
and removed request for
jpkrohling
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
==========================================
+ Coverage 96.16% 96.18% +0.01%
==========================================
Files 219 219
Lines 10632 10635 +3
==========================================
+ Hits 10224 10229 +5
+ Misses 352 351 -1
+ Partials 56 55 -1
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <[email protected]>
objectiser
approved these changes
May 7, 2020
| @@ -28,6 +28,7 @@ import ( | |||
|
|
|||
| "github.com/jaegertracing/jaeger/cmd/opentelemetry-collector/app/exporter/cassandra" | |||
| "github.com/jaegertracing/jaeger/cmd/opentelemetry-collector/app/exporter/elasticsearch" | |||
| "github.com/jaegertracing/jaeger/cmd/opentelemetry-collector/app/exporter/grpc" | |||
There was a problem hiding this comment.
minor, but think the exporter should be in package grpc-plugin to avoid confusion with the jaeger-grpc protocol exporter
There was a problem hiding this comment.
agree, I will refactor it
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2158