Add CLI flags for Kafka batching params

[apm-opentt]

Resolves #2037
The default Samara Kafka client writes to Kafka broker for every single span received.
This is not efficient and caused high CPU utilization on the brokers as well as high network traffic.
Samara Kafka client has options to enable batching. These options needed to be exposed
to the command for performance tuning. The option names matches official Kafka documentation and
not specific to Samara.

Signed-off-by: albert chung [email protected]

Which problem is this PR solving?

• See Expose Samara Kafka producer/consumer configurations to command line. #2037

Short description of the changes

• Added 2 new command line parameters for Kafka producer

[codecov]

Codecov Report

Merging #2047 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
- Coverage   97.41%   97.37%   -0.04%     
==========================================
  Files         207      207              
  Lines       10304    10304              
==========================================
- Hits        10038    10034       -4     
- Misses        223      225       +2     
- Partials       43       45       +2

Impacted Files	Coverage Δ
cmd/agent/app/processors/thrift_processor.go	100% <ø> (ø)	⬆️
cmd/query/app/server.go	91.66% <0%> (-2.78%)	⬇️
cmd/query/app/static_handler.go	86.84% <0%> (-1.76%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b2e39...e85f3d2. Read the comment docs.

[vprithvi]

I found this post to be a good read on the topic which contains experimental results on the effects of changing these parameters. (For instance, at high throughput they find that batch sizes up to 512KB increase total throughput)

[yurishkuro]

From my reading/grepping sarama code, I don't see Flush.MaxMessages, Flush.Bytes, or Flush.Frequency to be ever assigned any default values, which means they are 0 by default. And when they are zero, produceSet.readyToFlush() has this case:

	// If all three config values are 0, we always flush as-fast-as-possible
	case ps.parent.conf.Producer.Flush.Frequency == 0 && ps.parent.conf.Producer.Flush.Bytes == 0 && ps.parent.conf.Producer.Flush.Messages == 0:
		return true

So unless @vprithvi has some other thoughts, I think we have no batching by default, which means we can have 0s as default values for the new CLI flags to be backwards compatible.

[apm-opentt]

For some reason DCO check is red (x). I do have a signed-off-by in the commit. Can someone help?

Address code review issues

1. Set batch properties default to 0. ie. no default batching
2. Prefix batch properties with batch prefix
3. Added batch max messages for completeness
Resolves #2037

Signed-off-by: Albert Chung <[email protected]>

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# Date:      Wed Jan 29 16:24:38 2020 -0500
#
# On branch master
# Your branch is up to date with 'origin/master'.
#
# Changes to be committed:
#       modified:   pkg/kafka/producer/config.go
#       modified:   plugin/storage/kafka/options.go
#       modified:   plugin/storage/kafka/options_test.go
#

[yurishkuro]

you need to ensure that each commit is signed. If you missed some, the easiest fix is to git reset --soft to a hash before your changes and push as a single signed commit.

[apm-opentt]

@yurishkuro For some reason I am still having the DCO not passing. I did a git reset --soft then commit then push but it didn't work. Can you help provide the detail steps? Thanks!

[yurishkuro]

It complains about this commit: 04da10c

You need to find the commit hash in the upstream master from which you started your work. In the future I recommend using a branch in your fork, rather than master directly. Once you find the appropriate hash N, you run git reset --soft N. After this all your changes will be staged on top of an official commit, so git commit -sm 'Add CLI flags for Kafka batching params'.

[yurishkuro]

Thanks!