Handling of expected error codes coming from grpc storage plugins #1741 #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]>
chandresh-pancholi
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1814 +/- ##
=========================================
- Coverage 98.42% 98.4% -0.03%
=========================================
Files 197 197
Lines 9630 9633 +3
=========================================
+ Hits 9478 9479 +1
- Misses 116 117 +1
- Partials 36 37 +1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Sep 25, 2019
| @@ -61,7 +61,7 @@ func (c *grpcClient) GetTrace(ctx context.Context, traceID model.TraceID) (*mode | |||
| trace := model.Trace{} | |||
| for received, err := stream.Recv(); err != io.EOF; received, err = stream.Recv() { | |||
| if err != nil { | |||
| return nil, errors.Wrap(err, "grpc stream error") | |||
| return nil, spanstore.ErrTraceNotFound | |||
There was a problem hiding this comment.
This doesn't look right, why are you assuming that EVERY error from gRPC is "trace not found"?
…gertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]>
yurishkuro
reviewed
Oct 9, 2019
| }).Return(traceClient, nil) | ||
|
|
||
| s, err := r.client.GetTrace(context.Background(), mockTraceID) | ||
| assert.Error(t, err) |
There was a problem hiding this comment.
that doesn't test the issue, you probably want ErrorEquals method
There was a problem hiding this comment.
or simply assert.Equals(t, spanstore.ErrTraceNotFound, err)
…gertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]>
rubenvp8510
pushed a commit
to rubenvp8510/jaeger
that referenced
this pull request
Oct 10, 2019
…#1741 (jaegertracing#1814) * Handling of expected error codes coming from grpc storage plugins jaegertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]> * Handling of expected error codes coming from grpc storage plugins jaegertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]> Signed-off-by: Ruben Vargas <[email protected]>
radekg
pushed a commit
to Klarrio/jaeger
that referenced
this pull request
Oct 28, 2019
…#1741 (jaegertracing#1814) * Handling of expected error codes coming from grpc storage plugins jaegertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]> * Handling of expected error codes coming from grpc storage plugins jaegertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]> Signed-off-by: radekg <[email protected]>
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
…#1741 (jaegertracing#1814) * Handling of expected error codes coming from grpc storage plugins jaegertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]> * Handling of expected error codes coming from grpc storage plugins jaegertracing#1741 Signed-off-by: chandresh-pancholi <[email protected]> Signed-off-by: Jonah Back <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chandresh-pancholi [email protected]
Which problem is this PR solving?
Short description of the changes