Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Client Certificate for Elastic Search Authentication #678

Closed
reynaldiwijaya opened this issue Feb 5, 2018 · 9 comments
Closed

Using Client Certificate for Elastic Search Authentication #678

reynaldiwijaya opened this issue Feb 5, 2018 · 9 comments
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement
Milestone

Comments

@reynaldiwijaya
Copy link

Is there any plan to accommodate using client certificate for authenticating jaeger to ES? Our elastic search deployment is using search guard which only enable client certificate now, and we would like to keep it that way. ES is deployed in Kubernetes v1.9, and we would like to deploy Jaeger there as well.

If there are none, do you have any suggestion of workaround for this problem?

@yurishkuro
Copy link
Member

if the Go driver supports it, we can add the options similar to how they were added for Cassandra:

      --cassandra.tls                                        Enable TLS
      --cassandra.tls.ca string                              Path to TLS CA file
      --cassandra.tls.cert string                            Path to TLS certificate file
      --cassandra.tls.key string                             Path to TLS key file
      --cassandra.tls.server-name string                     Override the TLS server name
      --cassandra.tls.verify-host                            Enable (or disable) host key verification (default true)

@reynaldiwijaya
Copy link
Author

oh yeah thanks for update. Should we let this issue opened (in case the client updates it)? Please feel free to close it as well

@sneko
Copy link

sneko commented May 6, 2018

Hi @reynaldiwijaya! How did you manage that in a proper way please 😃 ?

@sneko
Copy link

sneko commented May 6, 2018

@yurishkuro I just saw that you are using the olivere/elastic client in Go.

I just checked their docs and found it's possible:
olivere/elastic#636
olivere/elastic#738

It would be really helpful using ES cluster through https 😀

Do you think it could be on the roadmap? I'm not used to Golang but if I could help by testing... it would be a pleasure 😃

@yurishkuro yurishkuro added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement labels May 6, 2018
@sneko
Copy link

sneko commented May 31, 2018

Hi @yurishkuro any news about having this on your roadmap?

Thanks :)

@isaachier
Copy link
Contributor

Honestly, seeing as we don't use ES internally, don't get too excited about seeing this on a roadmap any time soon.

@sneko
Copy link

sneko commented May 31, 2018

@isaachier oh ok that's too bad 😢

Anyway, thanks for this tool 😀 !

@yurishkuro
Copy link
Member

If the driver supports it, the change is fairy trivial, doesn't have to be done by official maintainers.

@reynaldiwijaya
Copy link
Author

@sneko hi im using cassandra at the end, works like a charm 👍

clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 25, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 25, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 26, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 26, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 29, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 29, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 31, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Oct 31, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Nov 2, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Nov 2, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Nov 5, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
clyang82 added a commit to clyang82/jaeger that referenced this issue Nov 5, 2018
Signed-off-by: Chun Lin Yang <[email protected]>
yurishkuro pushed a commit that referenced this issue Nov 9, 2018
* Fixed #678

Signed-off-by: Chun Lin Yang <[email protected]>

* Fixed #678

Signed-off-by: Chun Lin Yang <[email protected]>

* address review comments

Signed-off-by: Chun Lin Yang <[email protected]>

* address review comments

Signed-off-by: Chun Lin Yang <[email protected]>

* support timeout for non-tls-enabled case

Signed-off-by: Chun Lin Yang <[email protected]>

* change method name

Signed-off-by: Chun Lin Yang <[email protected]>
@yurishkuro yurishkuro added this to the 1.8 Release milestone Nov 9, 2018
@yurishkuro yurishkuro mentioned this issue Nov 9, 2018
7 tasks
liontwinkle added a commit to liontwinkle/go-jeager that referenced this issue Aug 1, 2020
* Fixed jaegertracing/jaeger#678

Signed-off-by: Chun Lin Yang <[email protected]>

* Fixed jaegertracing/jaeger#678

Signed-off-by: Chun Lin Yang <[email protected]>

* address review comments

Signed-off-by: Chun Lin Yang <[email protected]>

* address review comments

Signed-off-by: Chun Lin Yang <[email protected]>

* support timeout for non-tls-enabled case

Signed-off-by: Chun Lin Yang <[email protected]>

* change method name

Signed-off-by: Chun Lin Yang <[email protected]>
outdoorSpirit pushed a commit to outdoorSpirit/Go-Jag that referenced this issue May 3, 2024
* Fixed jaegertracing/jaeger#678

Signed-off-by: Chun Lin Yang <[email protected]>

* Fixed jaegertracing/jaeger#678

Signed-off-by: Chun Lin Yang <[email protected]>

* address review comments

Signed-off-by: Chun Lin Yang <[email protected]>

* address review comments

Signed-off-by: Chun Lin Yang <[email protected]>

* support timeout for non-tls-enabled case

Signed-off-by: Chun Lin Yang <[email protected]>

* change method name

Signed-off-by: Chun Lin Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

4 participants