-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Make ArchiveTrace button in the UI auto-configurable #4874
Comments
Hello @yurishkuro I would like to work on this issue can you please tell should I change the logic to this
|
on a high level - yes, but many details are wrong. You need to try in live code. |
Ok you assign me I will try and correct it |
we don't assign tickets, but feel free to implement |
## Which problem is this PR solving? - Resolves jaegertracing#4874 ## Description of the changes The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. ## How was this change tested? All corresponding tests have been updated. ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Antonin Barthelemy <[email protected]>
- Resolves jaegertracing#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]>
- Resolves jaegertracing#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]>
- Resolves jaegertracing#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]>
- Resolves jaegertracing#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]>
- Resolves jaegertracing#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]>
- Resolves jaegertracing#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]>
I have made the requested changes on the |
## Which problem is this PR solving? - backend part of #4874 ## Description of the changes The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. It is now possible to request features from the QueryService to inject them into the UI. Related UI change jaegertracing/jaeger-ui#1944 ## How was this change tested? All corresponding tests have been updated. ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Antonin Barthelemy <[email protected]> --------- Signed-off-by: Barthelemy Antonin <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
## Which problem is this PR solving? - Part of #4874 ## Description of the changes - Add some styling to the placeholder - Make the config substitutions directly visible - Add missing capabilities var ## How was this change tested? `go run ./cmd/all-in-one` <img width="902" alt="image" src="https://github.com/jaegertracing/jaeger/assets/3523016/0e08229c-f1f0-45cb-8e3f-e7f4daaa5337"> --------- Signed-off-by: Yuri Shkuro <[email protected]>
- Resolves jaegertracing/jaeger#4874 The button to archive a trace is now configured based on the state of the QueryService in addition to the UI configuration. All corresponding tests have been updated. - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully --------- Signed-off-by: Barthelemy Antonin <[email protected]> Signed-off-by: Barthelemy Antonin <[email protected]>
@thecoons Thank you for your contribution! 🎉 🎉 🎉 And for sticking with it during my picky code reviews :-) |
@yurishkuro I expected no less from you, and it's a pleasure to contribute to Jaeger. P.S.: Your book is a very interesting read :) |
When archive storage is configured in the query-service it can receive POST requests from the UI with a trace ID and clone that trace from primary storage into archive, useful for longer retention. However, the Archive Trace button has to be separately enabled in the UI for that, even though the query-service can check at runtime if archive storage is available.
Proposal
When query-service embeds the UI config into UI loading page, it can also include a structure describing the capabilities of the backend. One of the flags in this structure would be whether the archive storage is available, so that users wouldn't need to configure it separately in the UI. The same struct can be used to inform the UI of other things, for example whether more flexible queries are supported by the storage, like regex on tags (supported in ES but not in Cassandra).
We should still keep the enableArchive in the main UI config, but use it as a kill switch / override for archive function. When the UI decides whether to show the button, it would be
backendSupportsArchive && config.archiveEnabled
.Implementing this ticket requires some knowledge of both Go and Node.js
Details, Pointers
The
query-service
injects a config into UI loading page in the static handler:jaeger/cmd/query/app/static_handler.go
Line 120 in 089fc3c
The text was updated successfully, but these errors were encountered: