Fix collector panic due to sarama sdk returning nil error (#2654)

Signed-off-by: luhualin <[email protected]> Co-authored-by: luhualin <[email protected]>
jaegertracing · Nov 26, 2020 · 9bd0a8b · 9bd0a8b
1 parent b8ccf73
commit 9bd0a8b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/plugin/storage/kafka/writer.go b/plugin/storage/kafka/writer.go
@@ -57,7 +57,9 @@ func NewSpanWriter(
 	}()
 	go func() {
 		for e := range producer.Errors() {
-			logger.Error(e.Err.Error())
+			if e != nil && e.Err != nil {
+				logger.Error(e.Err.Error())
+			}
 			writeMetrics.SpansWrittenFailure.Inc(1)
 		}
 	}()