Skip to content

Commit

Permalink
fix comment and kafka integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
newly12 committed Apr 29, 2019
1 parent e335dcc commit 6357bae
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cmd/ingester/app/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const (
DefaultTopic = "jaeger-spans"
// DefaultGroupID is the default consumer Group ID
DefaultGroupID = "jaeger-ingester"
// DefaultGroupID is the default consumer Client ID
// DefaultClientID is the default consumer Client ID
DefaultClientID = "jaeger-ingester"
// DefaultParallelism is the default parallelism for the span processor
DefaultParallelism = 1000
Expand Down Expand Up @@ -111,6 +111,7 @@ func (o *Options) InitFromViper(v *viper.Viper) {
o.Brokers = strings.Split(stripWhiteSpace(v.GetString(KafkaConsumerConfigPrefix+SuffixBrokers)), ",")
o.Topic = v.GetString(KafkaConsumerConfigPrefix + SuffixTopic)
o.GroupID = v.GetString(KafkaConsumerConfigPrefix + SuffixGroupID)
o.ClientID = v.GetString(KafkaConsumerConfigPrefix + SuffixClientID)
o.Encoding = v.GetString(KafkaConsumerConfigPrefix + SuffixEncoding)

o.Parallelism = v.GetInt(ConfigPrefix + SuffixParallelism)
Expand Down
3 changes: 3 additions & 0 deletions plugin/storage/integration/kafka_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ func (s *KafkaIntegrationTestSuite) initialize() error {
s.logger, _ = testutils.NewLogger()
const encoding = "json"
const groupID = "kafka-integration-test"
const ClientID = "kafka-integration-test"
// A new topic is generated per execution to avoid data overlap
topic := "jaeger-kafka-integration-test-" + strconv.FormatInt(time.Now().UnixNano(), 10)

Expand Down Expand Up @@ -81,6 +82,8 @@ func (s *KafkaIntegrationTestSuite) initialize() error {
encoding,
"--kafka.consumer.group-id",
groupID,
"--kafka.consumer.client-id",
ClientID,
"--ingester.parallelism",
"1000",
})
Expand Down

0 comments on commit 6357bae

Please sign in to comment.