Add test for ProcessorFactory

Signed-off-by: Davit Yeghshatyan <[email protected]>

cmd/ingester/app/consumer/consumer_test.go

@@ -57,7 +57,6 @@ func TestConstructor(t *testing.T) {
 	newConsumer, err := New(params)
 	assert.NoError(t, err)
 	assert.NotNil(t, newConsumer)
-	assert.NotNil(t, newConsumer.processorFactory)
 
 	params.Builder = &mockConsumerConfiguration{
 		err: errors.New("consumerBuilder error"),

cmd/ingester/app/consumer/processor_factory.go

@@ -47,15 +47,15 @@ type ProcessorFactory struct {
 }
 
 // NewFactory constructs a new ProcessorFactory
-func (c *ProcessorFactory) NewFactory(params FactoryParams) *ProcessorFactory {
+func NewFactory(params FactoryParams) (*ProcessorFactory, error) {
 	return &ProcessorFactory{
 		topic:          params.Topic,
 		consumer:       params.Consumer,
 		metricsFactory: params.Factory,
 		logger:         params.Logger,
 		baseProcessor:  params.BaseProcessor,
 		parallelism:    params.Parallelism,
-	}
+	}, nil
 }
 
 func (c *ProcessorFactory) new(partition int32, minOffset int64) processor.SpanProcessor {

cmd/ingester/app/consumer/processor_factory_test.go

@@ -27,6 +27,13 @@ import (
 	"github.com/jaegertracing/jaeger/cmd/ingester/app/processor/mocks"
 )
 
+func Test_NewFactory(t *testing.T) {
+	params := FactoryParams{}
+	newFactory, err := NewFactory(params)
+	assert.NoError(t, err)
+	assert.NotNil(t, newFactory)
+}
+
 func Test_new(t *testing.T) {
 
 	mockConsumer := &kmocks.Consumer{}