Skip to content

Commit

Permalink
remove port option
Browse files Browse the repository at this point in the history
Signed-off-by: ohdearaugustin <[email protected]>
  • Loading branch information
ohdearaugustin committed May 15, 2020
1 parent 47a8d49 commit 054c1e5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions cmd/query/app/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ const (
type QueryOptions struct {
// HostPort is the host:port address that the query service listens o n
HostPort string
// Port is the port that the query service listens in on (deprecated, will be removed after 2020-06-30 or in release v1.20.0, whichever is later)
Port int
// BasePath is the prefix for all UI and API HTTP routes
BasePath string
// StaticAssets is the path for the static assets for the UI (https://github.com/uber/jaeger-ui)
Expand Down
2 changes: 1 addition & 1 deletion cmd/query/app/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (s *Server) Start() error {
}
s.conn = conn

tcpPort := s.queryOptions.Port
var tcpPort int
if port, err := netutils.GetPort(s.conn.Addr()); err == nil {
tcpPort = port
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/query/app/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestServerGracefulExit(t *testing.T) {

querySvc := &querysvc.QueryService{}
tracer := opentracing.NoopTracer{}
server := NewServer(flagsSvc, querySvc, &QueryOptions{Port: ports.QueryAdminHTTP}, tracer)
server := NewServer(flagsSvc, querySvc, &QueryOptions{HostPort: ports.PortToHostPort(ports.QueryAdminHTTP)}, tracer)
assert.NoError(t, server.Start())

// Wait for servers to come up before we can call .Close()
Expand Down

0 comments on commit 054c1e5

Please sign in to comment.