-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store preferred span name column width in localStorage #965
Conversation
6c58cbf
to
607831c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/duck.tsx
Show resolved
Hide resolved
607831c
to
eed3116
Compare
Different developers tend to look at different kinds of traces, meaning that they often prefer some set width of span name column in trace view. Without this patch, the width is set at 25% and it resets on refresh. With this patch the width is remembered in localStorage and preserved on refresh, making it less necessary to adjust. Signed-off-by: Ivan Babrou <[email protected]>
eed3116
to
718dbd6
Compare
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 95.43% 95.37% -0.06%
==========================================
Files 242 242
Lines 7552 7554 +2
Branches 1889 1890 +1
==========================================
- Hits 7207 7205 -2
- Misses 338 342 +4
Partials 7 7
Continue to review full report at Codecov.
|
Thanks! |
Different developers tend to look at different kinds of traces, meaning that they often prefer some set width of span name column in trace view.
Without this patch, the width is set at 25% and it resets on refresh. With this patch the width is remembered in localStorage and preserved on refresh, making it less necessary to adjust.
Posting it without a backing issue since it's a tiny change.