Monitor Tab - error rates - yDomain #913
Conversation
Signed-off-by: nofar9792 <[email protected]>
nofar9792
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 95.29% 95.26% -0.03%
==========================================
Files 240 240
Lines 7497 7502 +5
Branches 1870 1871 +1
==========================================
+ Hits 7144 7147 +3
- Misses 347 349 +2
Partials 6 6
Continue to review full report at Codecov.
|
| @@ -132,7 +132,7 @@ export class OperationTableDetails extends React.PureComponent<TProps, TState> { | |||
| <REDGraph | |||
| dataPoints={row.dataPoints.service_operation_error_rate} | |||
| color="#CD513A" | |||
| yDomain={[0, 100]} | |||
| yDomain={[0, 1]} | |||
There was a problem hiding this comment.
why is it that we have different yDomain in those two different files even though they both deal with error rate? Can we not converge on the same display methodology?
There was a problem hiding this comment.
in the main graph, we want to show values in percentages.
The value we get are between 1 to 100.
ini the operation table, the user doesn't see the values/legend, so it is easier just to change the yDomain
There was a problem hiding this comment.
That doesn't really answer my question - why have two different ways when we can have one?
To put it differently, as a way of blameless postmortem to the original change where you say "I made a mistake" - I think having a single representation would help avoiding such mistakes.
There was a problem hiding this comment.
multiple the values in the operation table will make the code more complex, I thought that in this case, it's better just to change the yDomain and not change the all the values
Signed-off-by: nofar9792 [email protected]
Which problem is this PR solving?
Resolves #912
Short description of the changes
I changed the wrong yDomain.
it affected the main error graph domain
before:
after:
