[fix]: deep dependency header overlaps page header (#731) #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stardotcode
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Bump up the z-index of page header element so that the deep dependency header doesn't overlap when scrolling down. Resolves jaegertracing#731 Signed-off-by: Neil Sharma <[email protected]>
stardotcode
force-pushed
the
stardotcode/issue-731
branch
from
b03cf32 to
cd7a516
Compare
rubenvp8510
approved these changes
Jul 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=======================================
Coverage 95.10% 95.10%
=======================================
Files 230 230
Lines 7010 7010
Branches 1745 1692 -53
=======================================
Hits 6667 6667
Misses 337 337
Partials 6 6 Continue to review full report at Codecov.
|
albertteoh
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Thanks @stardotcode! I tried it out and looks like this has fixed the problem.
leroy-chen
pushed a commit
to leroy-chen/jaeger-ui
that referenced
this pull request
Jul 16, 2021
jaegertracing#782) Bump up the z-index of page header element so that the deep dependency header doesn't overlap when scrolling down. Resolves jaegertracing#731 Signed-off-by: Neil Sharma <[email protected]> Signed-off-by: leroy-chen <[email protected]>
leroy-chen
pushed a commit
to leroy-chen/jaeger-ui
that referenced
this pull request
Jul 16, 2021
jaegertracing#782) Bump up the z-index of page header element so that the deep dependency header doesn't overlap when scrolling down. Resolves jaegertracing#731 Signed-off-by: Neil Sharma <[email protected]> Signed-off-by: leroy-chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
z-indexof page header element so that the deep dependency header doesn't overlap when scrolling down.