Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitter to slack #728

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh [email protected]

Which problem is this PR solving?

Short description of the changes

  • Update chat room link from gitter to slack.

albertteoh added 2 commits April 8, 2021 11:54
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #728 (d69ab56) into master (b5dd6f9) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   94.39%   94.42%   +0.03%     
==========================================
  Files         230      230              
  Lines        5959     5959              
  Branches     1448     1448              
==========================================
+ Hits         5625     5627       +2     
+ Misses        300      298       -2     
  Partials       34       34              
Impacted Files Coverage Δ
...ackages/jaeger-ui/src/constants/default-config.tsx 100.00% <ø> (ø)
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 79.31% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5dd6f9...d69ab56. Read the comment docs.

Copy link
Collaborator

@rubenvp8510 rubenvp8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurishkuro yurishkuro merged commit ae758fa into jaegertracing:master Apr 9, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jun 23, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants