Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: Make search panel more compact, button more visible #724

Merged
merged 5 commits into from
Apr 6, 2021
Merged

[feat]: Make search panel more compact, button more visible #724

merged 5 commits into from
Apr 6, 2021

Conversation

meenal06
Copy link
Contributor

@meenal06 meenal06 commented Apr 6, 2021 •
edited
Loading

Signed-off-by: Meenal Trivedi [email protected]

Which problem is this PR solving?

Short description of the changes

Screenshot

Screenshot 2021-04-07 at 1 04 22 AM

@meenal06
Copy link
Contributor Author

meenal06 commented Apr 6, 2021

Hi @jpkrohling @albertteoh please review

@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #724 (51163cb) into master (32f6f2f) will not change coverage.
The diff coverage is n/a.

❗ Current head 51163cb differs from pull request most recent head 3e65ae4. Consider uploading reports for the commit 3e65ae4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files         230      230           
  Lines        5959     5959           
  Branches     1448     1448           
=======================================
  Hits         5625     5625           
  Misses        300      300           
  Partials       34       34
Impacted Files Coverage Δ
...er-ui/src/components/SearchTracePage/SearchForm.js 90.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f6f2f...3e65ae4. Read the comment docs.

@jpkrohling
Copy link
Contributor

@rubenvp8510 would you be open to review this one?

@meenal06
Copy link
Contributor Author

meenal06 commented Apr 6, 2021

Hi @rubenvp8510 I have removed the code comments

@meenal06
chore: remove comments
98f5988 
Signed-off-by: Meenal Trivedi <[email protected]>
@rubenvp8510
Copy link
Collaborator

This LGTM, we only need to check Yuri comment to see if the search button color will be changed.

@meenal06
design button
480d78e 
Signed-off-by: Meenal Trivedi <[email protected]>
@meenal06
Copy link
Contributor Author

meenal06 commented Apr 6, 2021

Hi @rubenvp8510 @yurishkuro , I have made the button design changes to : color change with position right

@yurishkuro
Copy link
Member

please add a screenshot to the description

@meenal06
Copy link
Contributor Author

meenal06 commented Apr 6, 2021

Hi @yurishkuro , I have added the screenshot for my change in the pr-description. Please for review!

@yurishkuro yurishkuro changed the title feat: redesign the search box for jaeger-ui [feat]: Make search panel more compact, button more visible Apr 6, 2021
@yurishkuro yurishkuro merged commit b5dd6f9 into jaegertracing:master Apr 6, 2021
@yurishkuro
Copy link
Member

Thanks!

@meenal06 meenal06 deleted the fix branch April 6, 2021 21:18
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jun 23, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
5aa24a1 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
cf893e5 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
8973d8b 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
38a75da 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
0f91456 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
db0c26c 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
d2b5cdb 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
@meenal06 @vvvprabhakar
[feat]: Make search panel more compact, button more visible (jaegertr…
c76e541 
…acing#724)

* feat: redesign the search box for jaeger-ui

Signed-off-by: Meenal Trivedi <[email protected]>

* chore: remove comments

Signed-off-by: Meenal Trivedi <[email protected]>

* design button

Signed-off-by: Meenal Trivedi <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@everett980 everett980 Awaiting requested review from everett980

@tiffon tiffon Awaiting requested review from tiffon

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Search box UI and UX
4 participants
@meenal06 @jpkrohling @rubenvp8510 @yurishkuro