Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nvmrc from 8 to 10 #712

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

zoltanbedi
Copy link
Contributor

Which problem is this PR solving?

  • It solves the problem of building the repository. Running yarn on node 8 returns with an error.
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10.13.0". Got "8.17.0"
error Found incompatible module.

Signed-off-by: Zoltán Bedi <[email protected]>
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #712 (5080b8d) into master (0577ceb) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   94.39%   94.42%   +0.03%     
==========================================
  Files         230      230              
  Lines        5959     5959              
  Branches     1448     1448              
==========================================
+ Hits         5625     5627       +2     
+ Misses        300      298       -2     
  Partials       34       34              
Impacted Files Coverage Δ
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 79.31% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0577ceb...5080b8d. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, the CI also uses 10. Thanks!

@yurishkuro yurishkuro merged commit e4b5088 into jaegertracing:master Mar 4, 2021
@zoltanbedi zoltanbedi deleted the nvmrc10 branch March 4, 2021 17:27
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jun 23, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jun 23, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: vvvprabhakar <[email protected]>

Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants