-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move up redux from SpanTreeOffset #529
base: main
Are you sure you want to change the base?
Move up redux from SpanTreeOffset #529
Conversation
Signed-off-by: Andrej Ocenas <[email protected]>
Signed-off-by: Andrej Ocenas <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 92.92% 96.57% +3.64%
==========================================
Files 197 254 +57
Lines 4808 7620 +2812
Branches 1160 1986 +826
==========================================
+ Hits 4468 7359 +2891
+ Misses 299 261 -38
+ Partials 41 0 -41 ☔ View full report in Codecov by Sentry. |
@@ -19,11 +19,6 @@ jest.mock('./conv-raven-to-ga', () => () => ({ | |||
message: 'jaeger/a', | |||
})); | |||
|
|||
jest.mock('./index', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated but did not find a way around it. The error this produces is jestjs/jest#2567 because of the process
reference. I assume it could be caused be some dependency update but there is no lock file change here and I tried rm -rf node_modules
and reinstalls multiple times without luck. Anybody knows why this could be happening?
Regardless of the verdict on keeping span row visibility state in redux / some parent component (discussed here), I think this state can be hidden away in |
Which problem is this PR solving?
Short description of the changes
This based of #517 but I cannot create a PR with that target as that branch is on my fork so this is draft until that is merged.