Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ddg test coverage, fix typos #468

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • When implementing DDG some tests were skipped to meet a deadline.

Short description of the changes

  • This PR brings coverage of DDG-related files up to 100%

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #468 into master will increase coverage by 2.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #468      +/-   ##
=========================================
+ Coverage   89.41%   92.2%   +2.78%     
=========================================
  Files         192     192              
  Lines        4479    4477       -2     
  Branches     1073    1071       -2     
=========================================
+ Hits         4005    4128     +123     
+ Misses        428     307     -121     
+ Partials       46      42       -4
Impacted Files Coverage Δ
...c/model/ddg/GraphModel/getDerivedViewModifiers.tsx 100% <ø> (+100%) ⬆️
...omponents/DeepDependencies/Header/NameSelector.tsx 100% <ø> (+12.5%) ⬆️
...kages/jaeger-ui/src/model/ddg/visibility-codec.tsx 100% <ø> (ø) ⬆️
...components/DeepDependencies/Graph/getSetOnEdge.tsx 100% <100%> (+60%) ⬆️
...aeger-ui/src/components/DeepDependencies/index.tsx 100% <100%> (+26.82%) ⬆️
...er-ui/src/model/ddg/sample-paths.test.resources.js 100% <100%> (ø) ⬆️
...ts/DeepDependencies/Graph/DdgNodeContent/index.tsx 100% <100%> (+64.7%) ⬆️
...s/DeepDependencies/Header/LayoutSettings/index.tsx 100% <100%> (+84.21%) ⬆️
...ui/src/components/DeepDependencies/Graph/index.tsx 100% <100%> (+33.33%) ⬆️
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0%> (-1.7%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9a9ad...d47c7c3. Read the comment docs.

@everett980 everett980 merged commit d93b8e8 into jaegertracing:master Oct 25, 2019
@everett980 everett980 deleted the ddg-test-coverage branch October 25, 2019 17:21
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Increase ddg test coverage, fix typos
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants