-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Button to Reset Viewing Layer Zoom (#215) #290
Add a Button to Reset Viewing Layer Zoom (#215) #290
Conversation
Signed-off-by: Everett Ross <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 82.19% 82.19% +<.01%
==========================================
Files 141 141
Lines 3100 3101 +1
Branches 645 645
==========================================
+ Hits 2548 2549 +1
Misses 438 438
Partials 114 114
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, couple of minor questions.
packages/jaeger-ui/src/components/TracePage/SpanGraph/ViewingLayer.css
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/SpanGraph/ViewingLayer.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/SpanGraph/ViewingLayer.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/SpanGraph/ViewingLayer.test.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Everett Ross <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/jaeger-ui/src/components/TracePage/SpanGraph/ViewingLayer.js
Outdated
Show resolved
Hide resolved
…set-viewing-layer-zoom Signed-off-by: Everett Ross <[email protected]>
…racing#290) * Add button to reset viewing layer zoom (jaegertracing#215) Signed-off-by: Everett Ross <[email protected]> * Adhere to className pattern, sort imports, remove event handling Signed-off-by: Everett Ross <[email protected]> Signed-off-by: Everett Ross <[email protected]>
…racing#290) * Add button to reset viewing layer zoom (jaegertracing#215) Signed-off-by: Everett Ross <[email protected]> * Adhere to className pattern, sort imports, remove event handling Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
…racing#290) * Add button to reset viewing layer zoom (jaegertracing#215) Signed-off-by: Everett Ross <[email protected]> * Adhere to className pattern, sort imports, remove event handling Signed-off-by: Everett Ross <[email protected]> Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Which problem is this PR solving?
Short description of the changes