-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make changes to allow for /api/quality-metrics to work #2641
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: cs-308-2023 <[email protected]>
@yurishkuro Some tests are failing. I have to make changes in the .test.js files |
lgtm. Is it correct that this is a breaking change (different data shape is expected)? Please document it in the description. |
can you get the CI to green? Both linter and unit tests are failing. |
I didn't understand. Can you elaborate it a bit? What data shape is actually expected? |
You are now parsing data in a different shape than before (the "data" sub-structure in json) |
yes |
Signed-off-by: cs-308-2023 <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test