Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EmpasizedNode from class based to function based component #2638

Merged

Conversation

AdiIsHappy
Copy link
Contributor

@AdiIsHappy AdiIsHappy commented Jan 26, 2025

Which problem is this PR solving?

Converted EmphasizedNode in #2610

Description of the changes

How was this change tested?

Checklist

@AdiIsHappy AdiIsHappy requested a review from a team as a code owner January 26, 2025 16:50
@AdiIsHappy AdiIsHappy requested review from joe-elliott and removed request for a team January 26, 2025 16:50
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (57f5648) to head (95606e4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         255      255           
  Lines        7727     7728    +1     
  Branches     2006     2012    +6     
=======================================
+ Hits         7465     7466    +1     
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Aditya Sahu <[email protected]>
@yurishkuro yurishkuro enabled auto-merge January 26, 2025 19:00
@yurishkuro yurishkuro added this pull request to the merge queue Jan 26, 2025
Merged via the queue into jaegertracing:main with commit 48733c2 Jan 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants