updated react-icons #2603
Closed
updated react-icons #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: coderboy-yash <[email protected]>
coderboy-yash
requested review from
pavolloffay
and removed request for
a team
3 tasks
yurishkuro
reviewed
Jan 21, 2025
Thank you for replying, sir. Is this the only problem, or are there other issues as well? Please mention them so I can address everything at once |
yurishkuro
reviewed
Jan 21, 2025
| @@ -34,7 +34,7 @@ export default function LoadingIndicator(props: LoadingIndicatorProps) { | |||
| ${small ? 'is-small' : ''} | |||
| ${className || ''} | |||
| `; | |||
| return <LuLoader2 className={cls} {...rest} />; | |||
| return <LuLoader className={cls} {...rest} />; | |||
There was a problem hiding this comment.
why? There is LuLoaderCircle which looks more similar to the previous one.
|
addressed in #2518. Thanks for investigation that made the fix easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#2518 of #2576
Description of the changes
after going through the react-icons website I found that there is no LuLoader2 component in react-icons version"5.4.0" and some more people also mentioned the issue with LuLoader2 component.
so I have replace the LuLoader2 component with LuLoader component of react-icons.
loader icon before changes
loader icon after changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test