Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TraceDiff graph pan and zoom issue #2566

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

anshgoyalevil
Copy link
Member

@anshgoyalevil anshgoyalevil commented Jan 8, 2025

Which problem is this PR solving?

Description of the changes

  • This PR fixes the PAN and ZOOM functionality, which was caused by a minor CSS issue on the graph's parent that had relative position carried down the DOM to graph.

How was this change tested?

  • viewed the changes in browser by running jaeger-ui in dev, and jaeger monitor docker compose example.

Checklist

@anshgoyalevil anshgoyalevil requested a review from a team as a code owner January 8, 2025 03:09
@anshgoyalevil anshgoyalevil requested review from mahadzaryab1 and removed request for a team January 8, 2025 03:09
@anshgoyalevil
Copy link
Member Author

@yurishkuro It was a trivial fix so I think we can get it solved without waiting for a mentee to actually dig in

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 8, 2025
@yurishkuro
Copy link
Member

Thanks!

@yurishkuro yurishkuro enabled auto-merge (squash) January 8, 2025 03:11
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (c9ccd8b) to head (faaa39a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7728     7728           
  Branches     2015     2002   -13     
=======================================
  Hits         7468     7468           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 73a16c0 into jaegertracing:main Jan 8, 2025
8 of 9 checks passed
@anshgoyalevil anshgoyalevil deleted the fix-pan-zoom branch January 11, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants