Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: migrate ExamplesLink and EmphasizedNode components from enzyme to RTL #2066

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

EshaanAgg
Copy link
Contributor

@EshaanAgg EshaanAgg commented Dec 24, 2023

Which problem is this PR solving?

Fixes part of #1668

Description of the changes

  • Migrates ExamplesLink and EmphasizedNode components from enzyme to RTL
  • Replaces snapshot testing with actual test for the URLs

How was this change tested?

Running the tests locally

Checklist

@EshaanAgg EshaanAgg requested a review from a team as a code owner December 24, 2023 16:30
@EshaanAgg EshaanAgg requested review from yurishkuro and removed request for a team December 24, 2023 16:30
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cc0e88) 96.54% compared to head (834f0e6) 96.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2066   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         255      255           
  Lines        7622     7622           
  Branches     1985     1985           
=======================================
  Hits         7359     7359           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Dec 24, 2023
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 621ceb2 into jaegertracing:main Dec 24, 2023
10 of 11 checks passed
@EshaanAgg EshaanAgg deleted the enz2 branch December 24, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants