Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate: Migrate ExternalLinks component from enzyme to RTL #2065

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

EshaanAgg
Copy link
Contributor

Which problem is this PR solving?

Fixes part of #1668

Description of the changes

Migrate ExternalLinks component from enzyme to RTL

How was this change tested?

Ran the tests locally

Checklist

@EshaanAgg EshaanAgg requested a review from a team as a code owner December 24, 2023 15:18
@EshaanAgg EshaanAgg requested review from joe-elliott and removed request for a team December 24, 2023 15:18
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cc0e88) 96.54% compared to head (e192be6) 96.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
+ Coverage   96.54%   96.56%   +0.01%     
==========================================
  Files         255      255              
  Lines        7622     7622              
  Branches     1985     1985              
==========================================
+ Hits         7359     7360       +1     
+ Misses        263      262       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Dec 24, 2023
@yurishkuro yurishkuro merged commit c88b5fc into jaegertracing:main Dec 24, 2023
10 of 11 checks passed
@EshaanAgg EshaanAgg deleted the enz branch December 24, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants