-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date input is clipped in custom time selection #864
Comments
Thanks for the proposal @bobrik. I like the fact that date and time are together in one input to save real estate and remove the need to fill out another input just for time. However, it looks like it's not supported in IE, and perhaps why it was designed that way in Jaeger UI, because the workarounds I've read are to provide separate date and time inputs. |
Do we need to care about IE? Microsoft replaced it with Chromium based Edge 7 years ago and new feature development for IE stopped 6 years ago. |
I don't have strong opinion on Chromium/IE, but with the current implementation it looks like there is enough space to fit the ISO date, but something is slightly off with the style sheet. So the minimal fix would be to just fix the stylesheet. |
btw, I am not digging the s/s of the chromium date picker, it looks very unintuitive - wth are the two right columns? |
yes, let's try that first |
#867 takes care of this. |
Signed-off-by: Ivan Babrou <[email protected]>
Signed-off-by: Ivan Babrou <[email protected]>
Describe the bug
Date input is not fully visible (Macbook Pro 13", maximized window):
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Date can be entered without issues.
Version (please complete the following information):
Additional context
I think we can use
input
withtype="datetime-local"
rather than separate inputs for date and time. This also gives a nice picker, at least in Chrome:I'm happy to open a PR if you agree.
The text was updated successfully, but these errors were encountered: