Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date input is clipped in custom time selection #864

Closed
bobrik opened this issue Jan 7, 2022 · 7 comments · Fixed by #867
Closed

Date input is clipped in custom time selection #864

bobrik opened this issue Jan 7, 2022 · 7 comments · Fixed by #867
Labels

Comments

@bobrik
Copy link
Contributor

bobrik commented Jan 7, 2022

Describe the bug

Date input is not fully visible (Macbook Pro 13", maximized window):

image

To Reproduce

Steps to reproduce the behavior:

  1. Set date format to ISO8601:

image

  1. Open Jaeger UI
  2. Pick custom time range

Expected behavior

Date can be entered without issues.

Version (please complete the following information):

  • Jaeger version: 1.29, jaeger-ui build from the tip

Additional context

I think we can use input with type="datetime-local" rather than separate inputs for date and time. This also gives a nice picker, at least in Chrome:

image

I'm happy to open a PR if you agree.

@bobrik bobrik added the bug label Jan 7, 2022
@albertteoh
Copy link
Contributor

Thanks for the proposal @bobrik. I like the fact that date and time are together in one input to save real estate and remove the need to fill out another input just for time.

However, it looks like it's not supported in IE, and perhaps why it was designed that way in Jaeger UI, because the workarounds I've read are to provide separate date and time inputs.

@bobrik
Copy link
Contributor Author

bobrik commented Jan 14, 2022

Do we need to care about IE? Microsoft replaced it with Chromium based Edge 7 years ago and new feature development for IE stopped 6 years ago.

@yurishkuro
Copy link
Member

I don't have strong opinion on Chromium/IE, but with the current implementation it looks like there is enough space to fit the ISO date, but something is slightly off with the style sheet. So the minimal fix would be to just fix the stylesheet.

@yurishkuro
Copy link
Member

btw, I am not digging the s/s of the chromium date picker, it looks very unintuitive - wth are the two right columns?

@bobrik
Copy link
Contributor Author

bobrik commented Jan 14, 2022

Switching from ant-col-12 for both data and time to ant-col-14 for date and ant-col-8 for time also works:

image

Should I open a PR to do this instead of full datetime-local picker?

Using text input type rather than date also removes the clipping:
image

I think Crome adds a rather wide overlay for the date icon, and it has nothing to do with Jaeger stylesheets specifically:

image

@yurishkuro
Copy link
Member

Should I open a PR to do this instead of full datetime-local picker?

yes, let's try that first

@bobrik
Copy link
Contributor Author

bobrik commented Jan 14, 2022

#867 takes care of this.

bobrik added a commit to bobrik/jaeger-ui that referenced this issue Jan 14, 2022
yurishkuro pushed a commit that referenced this issue Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants