Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make help popup on the Search input field less intrusive #1651

Closed
anikdhabal opened this issue Aug 9, 2023 · 10 comments
Closed

Make help popup on the Search input field less intrusive #1651

anikdhabal opened this issue Aug 9, 2023 · 10 comments

Comments

@anikdhabal
Copy link
Contributor

What happened?

It's quite frustrating to see the tooltip every time when hovering over input fields; sometimes, they remain stuck on the page for an extended period of time.

Steps to reproduce

1.Hover over the page search input field.

Expected behavior

It would be better to have a specific button either inside or outside the input field instead of the whole input field. Clicking or hovering over that button would then trigger a popover to open, providing the information.

eg:
Just like this.
Screenshot 2023-08-09 053015
Or here
Screenshot 2023-08-09 054828

Relevant log output

No response

Screenshot

Screenshot 2023-08-09 054550

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@anikdhabal anikdhabal added the bug label Aug 9, 2023
@yurishkuro
Copy link
Member

I am trying this in the main branch and not getting any tooltip popup.

@anikdhabal
Copy link
Contributor Author

anikdhabal commented Aug 9, 2023

I am trying this in the main branch and not getting any tooltip popup.

Don't Know why, but I am getting it frequently in the UI.

@yurishkuro
Copy link
Member

I can see it now too, not sure why it wasn't working on my other laptop. Do you have a proposal what to replace it with? A visual mock up would be helpful.

@yurishkuro yurishkuro changed the title [Bug]: Add an info button to view a popover or a tooltip Make help popup on the Search input field less intrusive Aug 13, 2023
@anikdhabal
Copy link
Contributor Author

anikdhabal commented Aug 13, 2023

I can see it now too, not sure why it wasn't working on my other laptop. Do you have a proposal what to replace it with? A visual mock up would be helpful.

@yurishkuro I've added the expected behavior. Can we do it like that?

@yurishkuro
Copy link
Member

I don't follow.

@anikdhabal
Copy link
Contributor Author

I don't follow.

Instead of hover if the toot tip is appeared on focusing on the input, then it would be better. And we can make it clickable to remove. Means after clicking, it will automatically remove from the screen.

@yurishkuro
Copy link
Member

How would it make it less frustrating / intrusive? I thought you were talking about adding something like a (?) button

@anikdhabal
Copy link
Contributor Author

anikdhabal commented Aug 13, 2023

How would it make it less frustrating / intrusive? I thought you were talking about adding something like a (?) button

I've two visual representation-

Screenshot 2023-08-14 014824
It Appear on focus not when hovering.

Screenshot 2023-08-14 022158

Add a button.

@anikdhabal
Copy link
Contributor Author

@yurishkuro This is proposal for this issue. Do you have any additional idea to fix this issue?

@yurishkuro
Copy link
Member

button with question marks sounds good. Only it would be better to have it styled the same as the question mark in the Search panel.

yurishkuro pushed a commit that referenced this issue Aug 16, 2023
…1685)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- <!-- Example: Resolves #123 -->
#1651 
![Screenshot 2023-08-16
230437](https://github.com/jaegertracing/jaeger-ui/assets/81948346/84809799-4a3a-4ba5-8c60-10d1658d1912)


## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Anik Dhabal Babu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants