Set error span when error is a string value

jaegertracing · May 26, 2017 · 57b1890 · 57b1890
1 parent b943ad9
commit 57b1890
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/components/TracePage/TraceTimelineViewer/utils.js b/src/components/TracePage/TraceTimelineViewer/utils.js
@@ -104,7 +104,8 @@ export function hasTagKey(tags, key, value) {
 
 export const isClientSpan = span => hasTagKey(span.tags, 'span.kind', 'client');
 export const isServerSpan = span => hasTagKey(span.tags, 'span.kind', 'server');
-export const isErrorSpan = span => hasTagKey(span.tags, 'error', true);
+export const isErrorSpan = span =>
+  hasTagKey(span.tags, 'error', true) || hasTagKey(span.tags, 'error', 'true');
 
 /**
  * Returns `true` if at least one of the descendants of the `parentSpanIndex`

diff --git a/src/components/TracePage/TraceTimelineViewer/utils.test.js b/src/components/TracePage/TraceTimelineViewer/utils.test.js
@@ -94,6 +94,7 @@ const spanTypeTestCases = [
   { fn: isClientSpan, name: 'isClientSpan', key: 'span.kind', value: 'client' },
   { fn: isServerSpan, name: 'isServerSpan', key: 'span.kind', value: 'server' },
   { fn: isErrorSpan, name: 'isErrorSpan', key: 'error', value: true },
+  { fn: isErrorSpan, name: 'isErrorSpan', key: 'error', value: 'true' },
 ];
 
 spanTypeTestCases.forEach(testCase => {