Sidecar injection: Include the admin-http port #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Feb 24, 2020
|
Looks like GitHub CI is having some problems at the moment. I tried to re-run the jobs, but it kept failing. Would you be able to run a |
… scrape it Signed-off-by: Jonathan Rockway <[email protected]>
|
I did that, let's see how it goes! |
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Judging from the code, at some point the jaeger-agent accepted metrics scrapes on the other HTTP port (config-rest), but that is no longer the case. So this change exposes the admin-http port, which does accept metric scrapes.
(It appears that the 1.12.0 release changed this port, see jaegertracing/jaeger#1442 )
I am actually confused as to why any of the other ports are exposed; the idea of the sidecar is that these ports only show up to other containers in the pod on 127.0.0.1 and it would be somewhat harmful if other applications started sending traces to the pod address. But they're there, so I didn't touch them.