Fix route name for OCP

[pavolloffay]

Resolves https://issues.redhat.com/browse/TRACING-965

Fixes smoke test failures on OCP make e2e-tests-smoke caused probably by #891. Other related fixes #904 and #915

Signed-off-by: Pavol Loffay [email protected]

[jpkrohling]

Like the original PR addressing the length limitation, this might indicate a problem deeper than what originally thought. Is the test failing only because it's trying to lookup a route based on a truncated name? If so, the test should use util.Truncate instead. I would actually prefer tests with big names, so that we have more coverage for such cases.

[pavolloffay]

This is the failing log

Get https://my-jaeger-with-ingress-osdk-e2e-22fc72a5-db25-4707-876c-173229d49b42.apps.02-18-1582017833.devcluster.openshift.com/api/services: dial tcp: lookup my-jaeger-with-ingress-osdk-e2e-22fc72a5-db25-4707-876c-173229d49b42.apps.02-18-1582017833.devcluster.openshift.com: no such host

The instance name is the shortest part of the URL. Truncate should be called on the final URL but we do not have access to it.

This PR fixes the issue though.

[jpkrohling]

The instance name is the shortest part of the URL. Truncate should be called on the final URL but we do not have access to it.

The hostname is made of name and namespace of the route, and we can control the size of the name. This is what the actual code does to prevent creating an invalid route:

jaeger-operator/pkg/route/query.go

Lines 37 to 45 in 6b81f9d

	var name string
	if len(r.jaeger.Namespace) >= 63 {
	// the route is doomed already, nothing we can do...
	name = r.jaeger.Name
	r.jaeger.Logger().WithField("name", name).Warn("the route's hostname will have more than 63 chars and will not be valid")
	} else {
	// -namespace is added to the host by OpenShift
	name = util.Truncate(r.jaeger.Name, 62-len(r.jaeger.Namespace))
	}

[rubenvp8510]

I had the same problem as I mentioned in #904

This PR seems to fix the issue.

[pavolloffay]

To @jpkrohling note, the test code correctly gets the route and uses the hostname from the route to construct the URL for smoke test.

The problem might by that shortened URL is ending with - which is causing the failure.

[jpkrohling]

The problem might by that shortened URL is ending with - which is causing the failure.

There's a util.DNSName() that could be applied to the name after the util.Truncate() operation.

[pavolloffay]

I have changed the behavior, the issue was that the function was changing the length of the name and in our codebase the DNSName was applied after the truncation.

There is no need to use a and z as replacement chars. The original name cannot be reconstructed.

[jpkrohling]

Import is out of order :/

[pavolloffay]

goimports seems to be buggy. I will fix it manually.

[jpkrohling]

This one too