Handle test namespace creation and deletion as operator-sdk names are… #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… too long Signed-off-by: Kevin Earls <[email protected]>
|
Question: what exactly is failing? If it's the route that we talked before, then the bug is actually in the operator, as it shouldn't create a route with an invalid name. By the way, this is going to conflict with #897. |
|
@jpkrohling In one case it was definitely the route name. The others were not so obvious, so I was hoping to use this as a way to fix tests, and then investigate if necessary. I can investigate the other failures before proceeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… too long.
The update to operator-sdk 0.15.1 included a change where namespace names became much longer. https://github.com/operator-framework/operator-sdk/blob/master/pkg/test/context.go#L53 This resulted in a number of tests failing on OpenShift because of route names that were too long and other issues.
With this change tests run on OpenShift will manage the creation and deletion of namespaces instead of using the one created by the operator sdk.
Signed-off-by: Kevin Earls [email protected]